Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to LightDFG as default #364

Closed
3 tasks done
dehann opened this issue Aug 4, 2019 · 4 comments · Fixed by #584
Closed
3 tasks done

Transition to LightDFG as default #364

dehann opened this issue Aug 4, 2019 · 4 comments · Fixed by #584

Comments

@dehann
Copy link
Member

dehann commented Aug 4, 2019

what is the best way to introduce LightGraphsDFG and Arena. Guess the major decision is to move away from Graphs.jl to MetaGraphs.jl. Graphs.jl is on JuliaArchive, so long term prospects won't go too far there. Since Graphs.jl is working and has legacy I would not want just drop Graphs.jl outright. Can we make some plan to move LightGraphs.jl primary and drop Graphs.jl to secondary. So my suggestion is as follows:

  • IIF v0.8.x is clean new API on GraphsDFG and we start making sure LightGraphsDFG is ready to take the load,
  • IIF v0.9.x we switch to LightGraphsDFG as primary and demote GraphsDFG to secondary but keep around for several cycles,
  • Should we keep GraphsDFG into IIF v1.0.x LTS as secondary?

If it all goes well, IIF v1.1.x can probably deprecate GraphsDFG. There will still be something to do about BayesTree which currently still depends on Graphs.jl and ExVertex.

@dehann dehann added this to the v0.8.x milestone Aug 4, 2019
@dehann
Copy link
Member Author

dehann commented Aug 4, 2019

also see:
#365

@dehann dehann added the decision label Aug 4, 2019
@dehann dehann modified the milestones: v0.8.x, v0.9.x Aug 20, 2019
@dehann
Copy link
Member Author

dehann commented Sep 10, 2019

Not going to be LightGraphsDFG, but mayby LightDFG or SymbolDFG. WIll remain GraphsDFG as default for a while, and then switch once confidence in all code surrounding new in memory graph is obtained.

@Affie
Copy link
Member

Affie commented Sep 10, 2019

EDIT: Leverage existing repo's like LightGraphs.jl as LightDFG.


My opinion is to build on LightDFG as GraphsDFG replacement.
Summary for comparison:

  • LightDFG: DFG based directly on LightGraphs. All lightgraphs methods should be available. Keeps a label to internal id map. Factors and Variables are label indexed dictionaries.
  • SymbolDFG: DFG with adjacency as a symbol dictionary. Not completely compatible with LightGraphs, therefore it will be harder to maintain. Internal structure is factor/variable label
  • MetaGraphsDFG: DFG based on metagraphs. Allows for easily adding additional meta data.

@dehann dehann changed the title Transition to LightGraphsDFG as default Transition to LightDFG as default Jan 16, 2020
@dehann dehann modified the milestones: v0.9.x, v0.9.0 Jan 16, 2020
@dehann dehann linked a pull request Feb 17, 2020 that will close this issue
@dehann dehann closed this as completed Feb 17, 2020
@dehann
Copy link
Member Author

dehann commented Oct 18, 2020

Must make sure this is no longer an issue:
JuliaLang/julia#21356 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants