Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure lsf(..) returns order sensitive variables #256

Closed
dehann opened this issue Apr 12, 2019 · 2 comments
Closed

Make sure lsf(..) returns order sensitive variables #256

dehann opened this issue Apr 12, 2019 · 2 comments
Labels
check dfg good first issue help wanted
Milestone
v0.7.0

Comments

@dehann
Copy link
Member

dehann commented Apr 12, 2019 

addFactor!(fg, [:x1;:x2;:x3], ...)

lsf(fg, :x1x2x3f1) == [:x1;:x2;:x3]
@dehann dehann added this to the shortlist milestone Apr 12, 2019
@dehann
Copy link
Member Author

dehann commented Apr 12, 2019

needed to ensure #229 is done properly with subgraphs.

@dehann
Copy link
Member Author

dehann commented Apr 30, 2019

Hi @GearsAD , is this easy for you to confirm perhaps please?

@dehann dehann modified the milestones: shortlist, v0.7.x Apr 30, 2019
@dehann dehann modified the milestones: v0.7.x, v0.7.0 May 29, 2019
@dehann dehann added the dfg label May 29, 2019
@dehann dehann mentioned this issue Jun 10, 2019
Merged
@dehann dehann closed this as completed Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
check dfg good first issue help wanted
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
1 participant
@dehann