Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question, assert getSample / getMeasurement does not have access to graph variable solve values #1832

Open
dehann opened this issue Jun 14, 2024 · 2 comments

Comments

@dehann
Copy link
Member

dehann commented Jun 14, 2024

No description provided.

@dehann dehann added this to the v0.0.x milestone Jun 14, 2024
@Affie
Copy link
Member

Affie commented Jun 15, 2024

"""
$SIGNATURES
Sample the factor in `CalcFactor`. A default `getSample` method is provided that should cover most use cases,
if more advanced sampling is required, the `getSample` function should be extended.
The default behavior for `getSample` is as follows:
- The `SamplableBelief`` shall be in the field `Z` and that shall be enough to fully define the factor, i.e. `Z<:SamplableBelief` should be the only field.
- Sampling on `<:AbstractManifoldMinimize` factors defined on Group Manifolds:
- `getSample` normally returns a tangent vector at the identity element, however it should just match the custom factor definition.
- Sampling on prior (`<:AbstractPrior`) factors :
- `getSample` must return a point on the manifold that matches the point representation of the variable.
Notes
- Users should overload this method should their factor not only use field `Z` for the `SamplableBelief`.
- See the Custom Factors section in the Caesar.jl documentation for more examples and details.
- Also see issue https://github.com/JuliaRobotics/IncrementalInference.jl/issues/1441
See also: [`getMeasurementParametric`](@ref)
"""
function getSample end

Should have access to variables through calcFactor.

@Affie
Copy link
Member

Affie commented Jun 15, 2024

Parametric uses getFactorMeasurementParametric and getMeasurementParametric (get mean sigma)
Names should be upgraded though.
Parametric does not have full access to variables for performance reasons (use cache)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants