-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nonparametric heading test issue (in RoME.jl) #1760
Comments
try to do for v0.35.0, would like to ensure partials working properly for RoME. Small chance this punts to v0.35.1 given other priorities needing v0.35.0. |
spike and bump to v0.35.1 if taking too long |
Testing: So far |
this is new test coverage, and test looks at implicit partial priors and graph is still fully defined. Decision on how to handle these partials either explicit or code improvements with Manifolds. Way back before Manifolds and StaticArrays this would work because the implicit partial was handled automatically since all compute and variable assignments were done in coordinates and using manifold dims of variables and factors (i.e. xDim and zDim). |
requires new design session on partials, which expected to occur in the near future |
quick discussion had preference for always having "partial" info available for each factor. I.e. solver can recover necessary partial info for any factor. Preference to avoid having multiple factors for the same measurement type on different graphs. Example PriorPosition2/PriorPose2_XY/PriorPose3_XY. |
There has been some progress in understanding new design for partials, using dispatch with named dimensions during defVariable. Work still ongoing so going to delay in favor of sooner compat resolution in v0.35.5 |
See
@test_broken
here:The text was updated successfully, but these errors were encountered: