Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable, Immutable or both - points on manifold. #1372

Open
Affie opened this issue Aug 27, 2021 · 3 comments
Open

Mutable, Immutable or both - points on manifold. #1372

Affie opened this issue Aug 27, 2021 · 3 comments

Comments

@Affie
Copy link
Member

Affie commented Aug 27, 2021

It looks like we currently mutate the stored points on manifold in some places.
This makes it impossible to use bitstypes such as static arrays.
The CircularGroup manifold for example can use a complex number as representation that currently does not work.

In some cases mutating will be faster and sometimes replacing. So supporting both can also be an option.

An option to also consider is upgrading to something like the PowerManifold representation.

@dehann
Copy link
Member

dehann commented Aug 29, 2021

i'd say we should work towards mutable sized vector in general. For example, conv vs deconv have different needs on mutability of measurements.

i'd say finding performance enhancements local to some callstack situations using immutable manifold points is purely a performance thing and we should not go down the SVector road yet. Let's stay with Vector/MVector and ProductRepr (and replacement) for now?

Not sure if PowerManifold is a general solution for us since we don't use powers of the same manifold anywhere? I'm not following how that will fit in here, seems restrictive to me?

@dehann
Copy link
Member

dehann commented Sep 9, 2021

An option to also consider is upgrading to something like the PowerManifold representation.

this is probably not a IIF v0.25 thing

@dehann
Copy link
Member

dehann commented Jan 2, 2023

Note ccw.varValsAll and ccw.measurements should now be statically-typed and be using much more in-place logic during nonparametric inference (v0.32).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants