Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible compareAll bug #434

Open
Affie opened this issue May 3, 2020 · 3 comments
Open

Possible compareAll bug #434

Affie opened this issue May 3, 2020 · 3 comments
Labels
bug Something isn't working
Milestone
v0.0.x

Comments

@Affie
Copy link
Member

Affie commented May 3, 2020 

Expression: compareFactorGraphs(fg, fg2, skipsamples = true, skipcompute = true, skip = [:initialized; :inferdim; :ppeDict; :solvedCount])
  StackOverflowError:
  Stacktrace:
   [1] eval at ./boot.jl:331 [inlined]
   [2] eval at /home/travis/build/JuliaRobotics/DistributedFactorGraphs.jl/src/DistributedFactorGraphs.jl:11 [inlined]
   [3] compareField(::Core.TypeName, ::Core.TypeName, ::Symbol) at /home/travis/build/JuliaRobotics/DistributedFactorGraphs.jl/src/services/CompareUtils.jl:40
   [4] compareFields(::Core.TypeName, ::Core.TypeName; show::Bool, skip::Array{Symbol,1}) at /home/travis/build/JuliaRobotics/DistributedFactorGraphs.jl/src/services/CompareUtils.jl:56
   [5] compareAll(::Core.TypeName, ::Core.TypeName; show::Bool, skip::Array{Symbol,1}) at /home/travis/build/JuliaRobotics/DistributedFactorGraphs.jl/src/services/CompareUtils.jl:137
   [6] compareAll(::Type{Any}, ::Type{Any}; show::Bool, skip::Array{Symbol,1}) at /home/travis/build/JuliaRobotics/DistributedFactorGraphs.jl/src/services/CompareUtils.jl:146 (repeats 6686 times)
   [7] compareFactorGraphs(::LightDFG{SolverParams,DFGVariable,DFGFactor}, ::LightDFG{SolverParams,DFGVariable,DFGFactor}; skipsamples::Bool, skipcompute::Bool, skip::Array{Symbol,1}, show::Bool) at /home/travis/build/JuliaRobotics/DistributedFactorGraphs.jl/src/services/CompareUtils.jl:388
   [8] top-level scope at /home/travis/build/JuliaRobotics/DistributedFactorGraphs.jl/test/iifCompareTests.jl:65
   [9] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.4/Test/src/Test.jl:1113
   [10] top-level scope at /home/travis/build/JuliaRobotics/DistributedFactorGraphs.jl/test/iifCompareTests.jl:9
@Affie Affie added the bug Something isn't working label May 3, 2020
@Affie Affie added this to the mediumlist milestone May 3, 2020
@dehann
Copy link
Member

dehann commented May 3, 2020

A stackoverflow like this might mean a dispatch is calling the same function endlessly.

@Affie Affie modified the milestones: mediumlist, v0.8.x, v0.8.1 May 17, 2020
@dehann dehann modified the milestones: v0.8.1, v0.0.x Jul 6, 2020
@dehann
Copy link
Member

dehann commented Jul 6, 2020

Stackoverflow has usually for me been a function recursively calling itself endlessly

@Affie
Copy link
Member Author

Affie commented Jul 7, 2020

I'm going to leave this for now. I have some unfinished ideas on compare somewhere that will probably replace this.

@Affie Affie mentioned this issue Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.0.x
Development

No branches or pull requests
2 participants
@dehann @Affie