Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] References #46

Closed
HaoZeke opened this issue Sep 15, 2019 · 4 comments
Closed

[JOSS] References #46

HaoZeke opened this issue Sep 15, 2019 · 4 comments

Comments

@HaoZeke
Copy link

HaoZeke commented Sep 15, 2019

Hi,
Very minor issue brought up by @whedon here, openjournals/joss-reviews#1700 (comment)

Would be happy to close once it has been addressed.
image

@akabla
Copy link
Member

akabla commented Sep 15, 2019

Thanks so much Rohit @HaoZeke for checking.
Whedon is actually picking up a review of the book, and not the book itself. I can't find a doi for the book, and I'm not sure there is one. We'll look again.

@moustachio-belvedere
Copy link
Member

moustachio-belvedere commented Sep 15, 2019

Thanks for noting that @HaoZeke. Indeed, as @akabla mentioned, I can confirm that the DOI is a review of the book.

I did not notice it was a review at first and added in the DOI to the reference but Whedon still did not accept it so I looked a bit more closely. (This was during the pre-review openjournals/joss-reviews#1681 , commit 331db27 added it and then commit 3409c4a removed it once I had realised). I should have realised before as it is unusual for a book to have a DOI as far as I understand.

I will close the issue for now but please do let us know if you have any further queries on that.

Thanks again

edit: also worth noting that the paper.bib file has the full ISBN number for that book

@HaoZeke
Copy link
Author

HaoZeke commented Sep 15, 2019 via email

@moustachio-belvedere
Copy link
Member

No worries at all,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants