Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(JOSS) Documentation of Model Limitations #43

Closed
adambeall opened this issue Sep 12, 2019 · 3 comments
Closed

(JOSS) Documentation of Model Limitations #43

adambeall opened this issue Sep 12, 2019 · 3 comments
Assignees
Labels
documentation Related to documentation enhancement New feature or request

Comments

@adambeall
Copy link

Would it be possible to clarify in the paper and perhaps the documentation exactly what the requirements and limitations for a custom rheological model are? It appears that you can create any linear viscoelastic rheology as long as relaxation and / or creep moduli can be provided or fitted. The paper mentions an “emphasis on linear rheological models” and shows an example of the hereditary integral form for linear viscoelastic materials, however as someone coming from a different field, I interpreted these as options rather than strict model prerequisites. If you agree, it would only take a few added words to make this clearer.

On a related note, it may be useful to mention on the “Create Your Model” page in the documentation that it is also possible to build a model with only a creep modulus (provided only strain is predicted).

@akabla
Copy link
Member

akabla commented Sep 13, 2019

Thanks very much Adam @adambeall , this is a fair point indeed.
You are right that at the moment linearity is a constraint of the methods implemented, although we have some plans to extend this in future.
We will address this properly next week.

@akabla
Copy link
Member

akabla commented Sep 17, 2019

I have clarified the limitations of the current limitation of the library to the class of linear models, in the paper as well as in the doc intro.

Adam's comment regarding the "create your own model" section to follow.

@alebonfanti
Copy link
Member

Thanks a lot Adam @adambeall. We have addressed the linearity limitation in the "create your own model" as well as the possibility of defining a model with only one modulus.

The following commits should have resolved this issue:
f111401
2b67a91
41cfc64

Please let us know if you have further queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants