Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] Minor Markdown Formatting #38

Closed
HaoZeke opened this issue Sep 7, 2019 · 4 comments
Closed

[JOSS] Minor Markdown Formatting #38

HaoZeke opened this issue Sep 7, 2019 · 4 comments

Comments

@HaoZeke
Copy link

HaoZeke commented Sep 7, 2019

Hi. This is part of the JOSS review openjournals/joss-reviews#1700. I was wondering if the image in the paper might be made a bit smaller to improve the overall pdf formatting. Specifically, at the moment, there is almost over half a page of whitespace before Figure one, as shown visually in the screenshot.
image

@akabla
Copy link
Member

akabla commented Sep 7, 2019

Thanks very much Rohit, I agree with you, that is not optimal. I tried to make the figure more compact, but this does not really solve the problem on its own. We need to learn a bit more about how JOSS handles figure sizes and placement. We'll investigate next week!

@HaoZeke
Copy link
Author

HaoZeke commented Sep 7, 2019

Oh in that case, since I believe @whedon (and therefore JOSS) uses pandoc internally, you could play around with the following syntax:

![](file.jpg){ width=50% }

Which essentially becomes:

\includegraphics[width=0.5\textwidth,height=\textheight]{file.jpg}

I'll continue with the rest of the review in the meantime.

@HaoZeke
Copy link
Author

HaoZeke commented Sep 7, 2019

As of cf4a2b7
This has been resolved very nicely. Thanks!

@HaoZeke HaoZeke closed this as completed Sep 7, 2019
@akabla
Copy link
Member

akabla commented Sep 7, 2019

Fantastic! thanks so much Rohit.
It looks much better now. I'll play a bit more with the figure size later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants