Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead links in documentation #418

Closed
Krastanov opened this issue Jul 28, 2021 · 6 comments · Fixed by #420
Closed

Dead links in documentation #418

Krastanov opened this issue Jul 28, 2021 · 6 comments · Fixed by #420
Assignees

Comments

@Krastanov
Copy link

Hello,

I was trying to figure out the different between different trajectory storage objects, but VectorSARTTrajectory link in the Tutorial is dead and the trajectory links in the blog point to old archived repositories. There does not seem to be a general API documentation either, so I am a bit lost how to even see what is implemented. Any "first steps" directions would be appreciated. Maybe I am just looking at the incorrect documentation? https://juliareinforcementlearning.org/docs/

@Krastanov
Copy link
Author

There are actually a ton of links to https://github.com/JuliaReinforcementLearning/ReinforcementLearningBase.jl in the documentation which is archived, so I am a bit lost where to look for the up-to-date instructions and API.

@Krastanov
Copy link
Author

and most show nbview links in the experiments are broken (sorry I am reporting these as I find them hence the separate comments)

@findmyway findmyway self-assigned this Jul 29, 2021
@findmyway
Copy link
Member

findmyway commented Jul 29, 2021

@johnnychen94 It seems the link of the show nbview button is hardcoded? I can see those generated ipynb files under https://github.com/JuliaReinforcementLearning/JuliaReinforcementLearning.github.io/tree/master/docs/experiments/experiments/DQN

I think I'm using the latest version v0.4.3

@findmyway findmyway linked a pull request Jul 29, 2021 that will close this issue
@findmyway
Copy link
Member

Hello,

Hello~

I was trying to figure out the different between different trajectory storage objects, but VectorSARTTrajectory link in the Tutorial is dead and the trajectory links in the blog point to old archived repositories. There does not seem to be a general API documentation either, so I am a bit lost how to even see what is implemented. Any "first steps" directions would be appreciated. Maybe I am just looking at the incorrect documentation? https://juliareinforcementlearning.org/docs/

The link is right. It's just that many docs in trajectories are missing. Added some in #420 .

There are actually a ton of links to https://github.com/JuliaReinforcementLearning/ReinforcementLearningBase.jl in the documentation which is archived, so I am a bit lost where to look for the up-to-date instructions and API.

I tried to fix some of them. Let me know if there are still any other old links.

and most show nbview links in the experiments are broken (sorry I am reporting these as I find them hence the separate comments)

This is another issue. Let's track it in a separate issue.

@findmyway
Copy link
Member

@all-contributors please add @Krastanov for doc

@allcontributors
Copy link
Contributor

@findmyway

I've put up a pull request to add @Krastanov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants