Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagBot workflow does not trigger CI, preventing docs for tags #47

Closed
ericphanson opened this issue Jan 13, 2020 · 9 comments · Fixed by #49
Closed

TagBot workflow does not trigger CI, preventing docs for tags #47

ericphanson opened this issue Jan 13, 2020 · 9 comments · Fixed by #49

Comments

@ericphanson
Copy link
Member

This is probably known, but I didn't see an issue. The problem, as @SaschaMann pointed me to, is that it's hard to get workflows to trigger other workflows. So when using Github Actions for CI and for tagbot, even adding an on: release trigger to the CI workflow does not cause the tagbot workflow's tag to cause CI to run (I know this because I tried just now with the repo https://github.com/ericphanson/UnbalancedOptimalTransport.jl). Hence, the docs don't get built for the tag, and one doesn't get release docs (only dev docs).

I'll switch back to the bot version of tagbot instead of the workflow (which also has the advantage of being instant instead of waiting for a tag). But maybe this issue is something to consider re #39.

@christopher-dG
Copy link
Member

You should be able to fix this by overriding the GITHUB_TOKEN repo secret with your own token, but this unfortunately is a GitHub issue.

Relevant info: JuliaDocs/Documenter.jl#1177 and this GitHub Discourse post.

@DilumAluthge
Copy link
Member

@christopher-dG Does TagBot allow you to provide your own personal access token for use by TagBot?

@DilumAluthge
Copy link
Member

Whoops I see how easy it is. Just specify token:.

I’ll make a PR to add this to the TagBot documentation.

@christopher-dG
Copy link
Member

Really you don't need to change the workflow at all, you just need to set the repo secret in the settings.

@DilumAluthge
Copy link
Member

If you try to add a repo secret named GITHUB_TOKEN, you get the following error:

Failed to add secret. Name is invalid.

If I understand correctly, GitHub does not allow you to create a repo secret with a name that begins with GITHUB_. Those names are reserved for GitHub.

@christopher-dG
Copy link
Member

Oh, weird. I thought I read that you could "override" the default one by doing that, but I guess not.

@DilumAluthge
Copy link
Member

Note: GitHub reserves the GITHUB_ environment variable prefix for internal use by GitHub. Setting an environment variable or secret with the GITHUB_ prefix will result in an error.

From: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/using-environment-variables

@christopher-dG
Copy link
Member

christopher-dG commented Jan 14, 2020

Lame. I guess we can recommend setting a PERSONAL_ACCESS_TOKEN secret and updating the config appropriately then.

@DilumAluthge
Copy link
Member

#48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants