Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number consistency #432

Open
GunnarFarneback opened this issue Sep 13, 2021 · 3 comments
Open

Version number consistency #432

GunnarFarneback opened this issue Sep 13, 2021 · 3 comments

Comments

@GunnarFarneback
Copy link
Contributor

Nothing good will come if the registered version number does not match the version number in Project.toml in the given treehash. That these are consistent should be verified and should be easy to do as part of the "code can be loaded" check.

@ericphanson
Copy link
Member

True, though we only run automerge on registrator PRs currently and registrator gets its version from the source’s Project.toml, so there’d have to be a registrator bug for this to hit General at this time. So at least it can’t just be user-error. Agreed it’s a good check to have though.

@DilumAluthge
Copy link
Member

I think it's fine to add the check even if we assume that Registrator always do it correctly. We have some other checks (e.g. the list of files modified in a PR) that similarly should never fail on Registrator PR, but we still check it just as a internal consistency check.

@GunnarFarneback
Copy link
Contributor Author

In addition to possibly catching Registrator bugs this is a useful consistency check for people who run RegistryCI on their own registries, which may get PRs from other sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants