Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ECCO v0.0.1 #117204

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 13, 2024

Copy link
Contributor

github-actions bot commented Oct 13, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines which are not met ❌

  • Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.
  • Name is not at least 5 characters long

3. Needs action: here's what to do next

  1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
  2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

4. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@gaelforget
Copy link
Contributor

gaelforget commented Oct 13, 2024

I would like my pull request to be manually merged instead of via AutoMerge for ECCO.jl

Explanation : the chosen name ECCO.jl stands for Estimating the Circulation and Climate of the Ocean , a major academic effort which is widely known in the climate and ocean science community by its acronym, ECCO.

More detailed explanation:
ECCO is a 40+ years running effort initiated by Pr. Carl Wunsch at MIT, and which now involves distributed academic projects across the US (MIT, NASA JPL, UCSD, UTA, WHOI), Europe (AWI, UH), the UK (BAS), and more.
expanding the acronym would make the package name both (1) much harder to find by the targeted scientific community, and (2) a very long package name to type. And we would much rather avoid extending to "ECCOProject", "ECCOGroup", or something like that if it's just for the sake of the >4 character naming guideline.
if later on another package ended up being called ECCO.jl later, this would be damageable to our climate science and oceanography community building effort (again by making it harder for users to find the present package, and possibly turning them off from bridging to Julia, which is one of the goal of our creating this package).

Timeliness : this coming week, I intend to feature this package @ https://ecco-hackweek.github.io/ecco-2024/intro.html , and would therefore greatly appreciate if merging could be expedited.

UUID: 485acfd6-c8ad-4ff9-b233-a5c7cab2dfb0
Repo: https://github.com/gaelforget/ECCO.jl.git
Tree: 066d9899772dbe3e3a1d36d78d8caf22321a2d03

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@goerz
Copy link
Member

goerz commented Oct 13, 2024

I like the name, and I’d definitely support merging this. In my opinion, pronounceable acronyms should always be okay (it’s just hard for the bot to distinguish pronounceable from unpronounceable acronyms)

It’s not up to me, though. The 5 letter minimum rule can only be overridden with a manual merge from a registry maintainer.

You have to fix the compat issues first, though. Those are mandatory.

@gaelforget
Copy link
Contributor

I like the name, and I’d definitely support merging this. In my opinion, pronounceable acronyms should always be okay (it’s just hard for the bot to distinguish pronounceable from unpronounceable acronyms)

It’s not up to me, though. The 5 letter minimum rule can only be overridden with a manual merge from a registry maintainer.

Thanks for the feedback and supporting words! Makes me hopeful that a registry maintainer will agree with you and merge

You have to fix the compat issues first, though. Those are mandatory.

should be all set with compat now I think, following

Or am I overlooking something?

@gaelforget
Copy link
Contributor

Hi @goerz & @vchuravy

just giving this a ping to bring it back up on your radar. Would be awesome if this could be merged today.

I am almost ready to release the next version, v0.1.1, which I am hoping to do live as a demo tomorrow (at this hackweek).

@goerz
Copy link
Member

goerz commented Oct 17, 2024

I don't have merge permission, unfortunately, but yes, this should be merged as soon as possible, since the three-day period is up. If @vchuravy can't help you out with this, maybe ping the #pgk-registration channel on Slack.

I am almost ready to release the next version, v0.1.1

That seems like a version jump… Do you mean v0.1.0? In any case, do not try to register a new version before this PR is merged.

@gaelforget
Copy link
Contributor

I don't have merge permission, unfortunately, but yes, this should be merged as soon as possible, since the three-day period is up. If @vchuravy can't help you out with this, maybe ping the #pgk-registration channel on Slack.

Cool. Will give it a minute for now

I am almost ready to release the next version, v0.1.1

That seems like a version jump… Do you mean v0.1.0? In any case, do not try to register a new version before this PR is merged.

Good point. Did mean v0.1.0

@vchuravy vchuravy merged commit 494e7d2 into master Oct 18, 2024
16 of 19 checks passed
@vchuravy vchuravy deleted the registrator-ecco-485acfd6-v0.0.1-93e03ff83c branch October 18, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants