Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that a custom token is required for running GithHub Actions via CompatHelper.jl? #176

Closed
tkf opened this issue Jan 24, 2020 · 2 comments

Comments

@tkf
Copy link
Contributor

tkf commented Jan 24, 2020

FYI, I noticed that I had to pass a custom token for GithHub Actions to work in the PRs created by CompatHelper.jl. See this PR tkf/BenchmarkCI.jl#27 before the commit configuring custom token and this one tkf/BenchmarkCI.jl#31 after. Maybe it is worth noting it in the manual?

I realized this when reading this note in the manual of create-pull-request action: https://github.com/peter-evans/create-pull-request#action-inputs

@DilumAluthge
Copy link
Member

This is fixed now.

CompatHelper now supports SSH deploy keys. The solution is to use an SSH deploy key. See the CompatHelper README for full details.

We do not recommend that you use a personal access token (PAT). SSH deploy keys are more secure than PATs. For example, a PAT has access to all of your repositories, but an SSH deploy key only has access to a single repository.

@tkf
Copy link
Contributor Author

tkf commented Jun 2, 2020

Thanks a lot for adding the deploy key support. It's good to know that CompatHelper.jl is taking security seriously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants