Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify overapproximation option in BFFPSV18 #628

Closed
mforets opened this issue May 1, 2019 · 1 comment · Fixed by #633
Closed

Simplify overapproximation option in BFFPSV18 #628

mforets opened this issue May 1, 2019 · 1 comment · Fixed by #633
Assignees

Comments

@mforets
Copy link
Member

mforets commented May 1, 2019

get_overapproximation_option in the discrete post is there to make the transformation from template directions symbols (alias) to arguments that are accepted by LazySets overapproximate. In JuliaReach/LazySets.jl#1329 it is proposed to move that part directly to LazySets. Then get_overapproximation_option can be dropped with the advantage that future updates in LazySets overapproximate are available.

In the meantime, PR #627 allows to use template dirs in the discrete post by adding more checks.

@schillic
Copy link
Member

In #633 I remove these symbols for simplicity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants