Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept non-hyperrectangular sets for the discretization with zonotopes #530

Closed
mforets opened this issue Mar 8, 2019 · 2 comments
Closed
Labels

Comments

@mforets
Copy link
Member

mforets commented Mar 8, 2019

In #528 we added the option set_operations with default value "lazy". If set_operations is "zonotope", it uses concrete operations between zonotopes, and needs to convert to zonotope. Sets such as Ball2 is not allowed.

Proposal: if convert(Zonotope, X0) is not available, call overapproximate(X0, Zonotope) or (if it is not defined), just convert(Zonotope, overapproximate(X0, Hyperrectangle)).

@schillic
Copy link
Member

schillic commented Mar 8, 2019

I changed my mind here.
It does not make sense to use zonotopes if the sets in the input are not given as zonotopic sets. Since there is (probably) no generic overapproximation method for zonotopes, unexpected things can happen.
I would say that the user should take care of the conversion in advance. Hence I would say that we can keep the existing converts.

@mforets
Copy link
Member Author

mforets commented Mar 8, 2019

Alright, agreed.

@mforets mforets closed this as completed Mar 8, 2019
@schillic schillic added wontfix and removed extension labels Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants