Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vertices and vertices_list #385

Closed
mforets opened this issue Jul 20, 2018 · 1 comment
Closed

vertices and vertices_list #385

mforets opened this issue Jul 20, 2018 · 1 comment
Assignees
@schillic
Labels
simplification 👶 Simplifies code

Comments

@mforets
Copy link
Member

mforets commented Jul 20, 2018

I see some sort of asymmetry between VPolygon's vertices_list field and VPolytope vertices field, compared to HPolygon and HPolytope fields's constraints. Note that we have methods constraints_list and vertices_list.

Proposal: change VPolygon's field to vertices.
@mforets mforets added the discussion 🗣️ Requires human input label Jul 20, 2018
@schillic schillic added simplification 👶 Simplifies code and removed discussion 🗣️ Requires human input labels Jul 21, 2018
@schillic
Copy link
Member

Good finding, I totally agree 👍

@schillic schillic self-assigned this Jul 22, 2018
@schillic schillic mentioned this issue Jul 22, 2018
Merged
schillic added a commit that referenced this issue Jul 25, 2018
@schillic
Merge pull request #386 from JuliaReach/schillic/385
a353be1 
#385 `vertices` and `vertices_list`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schillic schillic

Labels
simplification 👶 Simplifies code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schillic @mforets