-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make VPolygon's vertices field be abstract #927
Comments
I do not understand the suggestion. |
To change the field |
Okay, I agree, but some comments:
|
The outer container may be kept as a usual vector, no? But as in the example of above, you may want to change the container of the points. For instance it makes sense to use static vectors to represent many vectors in 2D or 3D, but it is not so suited for holding a large number of vectors (the outer container).
True, i think we can as well generalize
My concern was about avoiding fields with abstract type. |
Why? 😃
I do not expect that in 2D you have a large number anyway.
Okay, I was not sure anymore if it had impact on efficiency. In that case of course we should add a type parameter. Note that at some places we may have the assumption that the type of points is |
The text was updated successfully, but these errors were encountered: