Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher dimensional line #652

Closed
mforets opened this issue Sep 22, 2018 · 5 comments · Fixed by #2210
Closed

Higher dimensional line #652

mforets opened this issue Sep 22, 2018 · 5 comments · Fixed by #2210
Assignees
Labels
feature ➕ A new feature refactoring 🔧 Internal code changes, typically no impact on API

Comments

@mforets
Copy link
Member

mforets commented Sep 22, 2018

Line is currently 2D set, but one could take it to also mean the n-dim set defined by the points p such that p = d*l + lo, where lo is a point on the line, d is a real number, and l is the direction of the line.

@schillic
Copy link
Member

So what is your proposal? Generalize this type? Add a new type?

@schillic schillic added the discussion 🗣️ Requires human input label Sep 23, 2018
@mforets
Copy link
Member Author

mforets commented Sep 23, 2018

generalize this type.

@schillic schillic added feature ➕ A new feature refactoring 🔧 Internal code changes, typically no impact on API and removed discussion 🗣️ Requires human input labels Sep 24, 2018
@schillic
Copy link
Member

I suggest to also keep the old type for specializations. A name could be Line2 (I have seen that before) or Line2D.

@mforets
Copy link
Member Author

mforets commented Sep 24, 2018

Do we have some examples that can use this specialization? I checked a bit and didn't see this advantage, then i said let's don;t specialize (yet).

@schillic
Copy link
Member

Do we have some examples that can use this specialization?

The vertices_list(::AbstractHPolygon) function. And we might have to remove the concrete intersection implementation if it only works in 2D (not sure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ➕ A new feature refactoring 🔧 Internal code changes, typically no impact on API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants