Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching lazy set operations #351

Closed
schillic opened this issue May 23, 2018 · 4 comments
Closed

Caching lazy set operations #351

schillic opened this issue May 23, 2018 · 4 comments
Labels
feature ➕ A new feature performance 🐎 More efficient code

Comments

@schillic
Copy link
Member

(outsourced from a comment by @mforets in #342)
Generalize the approach of CacheMinkowskiSum to other set representations. As a design strategy, in a future revision we could use composition like:

struct CachedLazySet{N, ST<:LazySet{N}, CT} <: LazySet
    X::ST
    cache::CT
end

This could possibly be outsourced to a macro.

@schillic schillic added feature ➕ A new feature performance 🐎 More efficient code labels May 23, 2018
@mforets
Copy link
Member

mforets commented Jun 7, 2018

The cached MinkowskiSumArray turned out to give very good results in practice. I think this feature is worth adding, since it can be interesting for other applications.

@mforets
Copy link
Member

mforets commented Jun 7, 2018

For the macro approach, we should check Mixers, this package is providing such technology for type extensions.

@schillic
Copy link
Member Author

schillic commented Jun 7, 2018

The cached MinkowskiSumArray turned out to give very good results in practice. I think this feature is worth adding, since it can be interesting for other applications.

Note that it was only so efficient because we could remove the sets again and thus skip repeated computations. This is because of the linearity of the support vector for the sum. Without this property I do not expect good performance.

@schillic
Copy link
Member Author

schillic commented Apr 6, 2023

I close this issue because I think it is unclear what to do.

@schillic schillic closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ➕ A new feature performance 🐎 More efficient code
Projects
None yet
Development

No branches or pull requests

2 participants