Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifations of sspz #3005

Closed
mforets opened this issue Jul 15, 2022 · 2 comments · Fixed by #3009
Closed

Simplifations of sspz #3005

mforets opened this issue Jul 15, 2022 · 2 comments · Fixed by #3009
Assignees
Labels
performance 🐎 More efficient code

Comments

@mforets
Copy link
Member

mforets commented Jul 15, 2022

The example added here highlights that we should have a simplification function such that:

  • Zero columns in G can be eliminated.
  • Zero columns in E can be associated with the center for the corresponding generator.
  • Repeated columns in E can be grouped together by summing the corresponding generators.

(This simplification is exact btw)

cc @lucaferranti

@mforets mforets added the performance 🐎 More efficient code label Jul 15, 2022
@lucaferranti
Copy link
Member

good catch, should we do this simplification always automatically in the constructor or should there be a function that must be explicitally called if the user wants to simplify, do you have something similar for other sets?

@lucaferranti lucaferranti self-assigned this Jul 15, 2022
@mforets
Copy link
Member Author

mforets commented Jul 15, 2022

Maybe we can start by just writing a function remove_redundant_generators (there is one with the same name already for Zonotopes). Instead of applying it in the constructor, I think I'd rather use it in quadratic_map and other places that may produce redundant generators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance 🐎 More efficient code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants