update cached MSA docstrings #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
commented
Apr 1, 2021
| @@ -140,7 +139,7 @@ If the direction has norm zero, the result depends on the summand sets. | |||
|
|
|||
| The result is cached, i.e., any further query with the same direction runs in | |||
| constant time. | |||
| When sets are added to the caching Minkowski sum, the query is only performed | |||
| When sets are added to the cached Minkowski sum, the query is only performed | |||
There was a problem hiding this comment.
in several places we had caching instead of cached. i think we should use only one name (?) so cached is better since it is part of the type's name.
22 tasks
schillic
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1837.
This file updates the Cached MinkowskiSumArray.
Unrelated: the struct
CachedPairhas an abstract field. We should change it toVector{N}or add a new field.