Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve namespace conflicts with other packages #194

Closed
schillic opened this issue Jan 27, 2018 · 2 comments
Closed

Resolve namespace conflicts with other packages #194

schillic opened this issue Jan 27, 2018 · 2 comments
Labels
wontfix 🔕 This will not be worked on

Comments

@schillic
Copy link
Member

schillic commented Jan 27, 2018

There might be no solution here, because name conflicts are in general unavoidable.
We could think about not exporting some of the symbols, but that sounds stupid.

  • Polyhedra warnings
julia> using LazySets, Polyhedra

# press TAB
julia> WARNING: both Polyhedra and LazySets export "HalfSpace"; uses of it in module Main must be qualified
WARNING: both Polyhedra and LazySets export "Interval"; uses of it in module Main must be qualified
WARNING: both Polyhedra and LazySets export "Line"; uses of it in module Main must be qualified
WARNING: both Polyhedra and LazySets export "dim"; uses of it in module Main must be qualified
  • IntervalArithmetic warnings
    Note that the warnings do not appear when only typing using LazySets (because IntervalArithmetic is only loaded internally). So I think we can ignore this.
julia> using LazySets, IntervalArithmetic

# press TAB
julia> WARNING: both LazySets and IntervalArithmetic export "Interval"; uses of it in module Main must be qualified
WARNING: both IntervalArithmetic and LazySets export "isdisjoint"; uses of it in module Main must be qualified
WARNING: both LazySets and IntervalArithmetic export "radius"; uses of it in module Main must be qualified
WARNING: both LazySets and IntervalArithmetic export ""; uses of it in module Main must be qualified
  • Plots warning
julia> using LazySets, Plots

# press TAB
julia> WARNING: both Plots and LazySets export "center"; uses of it in module Main must be qualified
@schillic schillic added the bug 🐛 Something isn't working label Jan 27, 2018
@schillic schillic changed the title Resolve namespace conflicts with Polyhedra.jl Resolve namespace conflicts with other packages Mar 6, 2018
@mforets
Copy link
Member

mforets commented Apr 4, 2018

i think we can close this?

@schillic
Copy link
Member Author

schillic commented Apr 5, 2018

I restructured the first post to collect everything we have here.
I think we cannot solve the namespace conflicts, but we should at least make the unit tests robust against known problems.

  • Polyhedra crash
julia> using Polyhedra; include("runtests.jl")
[...]
WARNING: both LazySets and Polyhedra export "dim"; uses of it in module Main must be qualified
LazySets.Ball2: Error During Test
  Test threw an exception of type UndefVarError
  Expression: dim(b) == 1
  UndefVarError: dim not defined
[...]

This has been resolved at some point.

@schillic schillic added fix 🤕 Fix to a problem that is not too serious and removed bug 🐛 Something isn't working labels Jun 6, 2018
@schillic schillic added wontfix 🔕 This will not be worked on and removed fix 🤕 Fix to a problem that is not too serious labels Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix 🔕 This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants