Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vertices_list for HPolytope #168

Closed
schillic opened this issue Jan 21, 2018 · 1 comment
Closed

Implement vertices_list for HPolytope #168

schillic opened this issue Jan 21, 2018 · 1 comment
Assignees
Labels
bug 🐛 Something isn't working feature ➕ A new feature
Milestone

Comments

@schillic
Copy link
Member

schillic commented Jan 21, 2018

We have HPolytope <: AbstractPolytope, but this interface requires an implementation of vertices_list. Consequently, some operations break.

There is a bug in the interface checking function, hence we did not detect that this function is missing.

Actually, if we have vertices_list, we might as well add VPolytope because we get tovrep for free (we can leave tohrep open for now).

@schillic schillic added the bug 🐛 Something isn't working label Jan 21, 2018
@schillic schillic added this to the v1.1.0 milestone Jan 21, 2018
@mforets
Copy link
Member

mforets commented Jan 22, 2018

yes; this is an instance to use the polyhedra manipulation library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working feature ➕ A new feature
Projects
None yet
Development

No branches or pull requests

2 participants