From 5ae7e26504c038c05856216da628f5441288f5a8 Mon Sep 17 00:00:00 2001
From: schillic <git@christianschilling.net>
Date: Wed, 24 Apr 2024 08:23:49 +0200
Subject: [PATCH] binary convex_hull with EmptySet: use unary

---
 src/ConcreteOperations/convex_hull.jl  |  4 +---
 test/ConcreteOperations/convex_hull.jl | 21 +++++++++++++++++++--
 2 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/src/ConcreteOperations/convex_hull.jl b/src/ConcreteOperations/convex_hull.jl
index 4cb06c0488..69b811f50d 100644
--- a/src/ConcreteOperations/convex_hull.jl
+++ b/src/ConcreteOperations/convex_hull.jl
@@ -562,9 +562,7 @@ function convex_hull(P1::HPoly, P2::HPoly;
 end
 
 @commutative function convex_hull(X::LazySet, ::EmptySet)
-    @assert isconvextype(typeof(X)) "this implementation requires a convex " *
-                                    "set as input"
-    return X
+    return convex_hull(X)
 end
 
 convex_hull(∅::EmptySet, ::EmptySet) = ∅
diff --git a/test/ConcreteOperations/convex_hull.jl b/test/ConcreteOperations/convex_hull.jl
index 87f25405bf..91c2c191ca 100644
--- a/test/ConcreteOperations/convex_hull.jl
+++ b/test/ConcreteOperations/convex_hull.jl
@@ -17,8 +17,8 @@ for N in [Float64, Rational{Int}]
     @test convex_hull([[N(1), N(0)], [N(1), N(0)]]) == [[N(1), N(0)]]
 
     # test corner cases with one and two vectors (see #876)
-    p1 = [1.0, 2.0]
-    p2 = [1.0, 3.0]
+    p1 = N[1, 2]
+    p2 = N[1, 3]
     @test convex_hull([p1]) == [p1]
     @test ispermutation(convex_hull([p1, p2]), [p1, p2])
 
@@ -168,4 +168,21 @@ for N in [Float64, Rational{Int}]
     @test isequivalent(convex_hull(U), P)
     U = UnionSetArray([convert(HPolytope, V1), convert(HPolytope, V2)])
     @test isequivalent(convex_hull(U), P)
+
+    # ==========================
+    # Unary concrete convex hull
+    # ==========================
+
+    # convex set
+    S = Singleton(N[1])
+    @test convex_hull(S) == S
+
+    # non-convex set
+    P = Polygon([N[0, 0], N[0, 2], N[2, 2], N[2, 0], N[1, 1]])
+    Pc = VPolygon([N[0, 0], N[2, 0], N[2, 2], N[0, 2]])
+    @test convex_hull(P) == Pc
+
+    # binary convex hull with an empty set is identical to unary
+    @test convex_hull(S, EmptySet{N}(1)) == convex_hull(EmptySet{N}(1), S) == S
+    @test convex_hull(P, EmptySet{N}(1)) == convex_hull(EmptySet{N}(1), P) == Pc
 end