You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for your work. Most of it looks good to me, but it would be great if you could address the following suggestions and points as part of the JOSS submission Review Process.
JOSS Paper
Add a reference for tensor networks and explain how it works.
Mention how it is better or different from other packages (if any) that supposedly intend to quantum circuit simulations in a similar fashion either in Julia or other languages.
Mention if there are any limitations of this package.
Repository
There definitely needs to be some tutorials (or documentation) for the following things:
i. Explaining details of the workflow step by step as already mentioned in Add tutorial notebook which demonstrates basic workflow #5.
ii. Provide the performance benchmarks for the package (see the point below).
While looking at the repository and the documentation, I could not see any particular examples or relevant results for the following statement.
To reduce the turnaround time and allow larger systems to be simulated, it is necessary to move beyond single workstations and use distributed compute clusters.
While it being obvious, it would be beneficial if some useful examples (or even better if some tutorials) could be added to showcase how this package reduces simulation time.
Add the link of the documentation explicitly in the README. It might not be evident to the user to access it via badge.
[Suggestion] I had a look at the contributing guidelines and the pull request template, and they look good! However, I would suggest you have a template for Issues as well, making the user's task a bit easier to request new features or report any bugs.
Remember that all issues are open to discussion, and additional considerations are welcome!
The text was updated successfully, but these errors were encountered:
Dear authors,
Thank you for your work. Most of it looks good to me, but it would be great if you could address the following suggestions and points as part of the JOSS submission Review Process.
JOSS Paper
tensor networks
and explain how it works.Repository
There definitely needs to be some tutorials (or documentation) for the following things:
i. Explaining details of the workflow step by step as already mentioned in Add tutorial notebook which demonstrates basic workflow #5.
ii. Provide the performance benchmarks for the package (see the point below).
While looking at the repository and the documentation, I could not see any particular examples or relevant results for the following statement.
While it being obvious, it would be beneficial if some useful examples (or even better if some tutorials) could be added to showcase how this package reduces simulation time.
Add the link of the documentation explicitly in the
README
. It might not be evident to the user to access it via badge.[Suggestion] I had a look at the contributing guidelines and the pull request template, and they look good! However, I would suggest you have a template for Issues as well, making the user's task a bit easier to request new features or report any bugs.
Remember that all issues are open to discussion, and additional considerations are welcome!
The text was updated successfully, but these errors were encountered: