-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically suggest fixes for bad formatting #53
Conversation
xref https://julialang.slack.com/archives/CPWJ5DGG1/p1726659724707129 according to @JoshuaLampert on Slack, this action will only work on PRs which is not from a fork :-/ |
For reference: JuliaDiff/ChainRulesCore.jl#489 |
So should we revert this change and set PlutoTeachingTools.jl/test/test_linting.jl Lines 9 to 11 in 0d18e3d
|
I think it's a good idea to change to Also, it doesn't hurt to keep this PR. At least you, @eford and others with write-access get better feedback from the formatter. |
I was also frustrated by getting an error, but having no clue what was causing it or how to fix it. So I like the idea of making sure that any CI errors due to formatting are accompanied by explicit instructions that are useful even a domain expert who is not an expert at software development patterns. But I don't have time to test now, so I'll hope it's fixed and return to it if I encounter another unhelpful error message in the future. |
Sorry, I didn't expect this formatting test to cause so much trouble. |
copy-paste from https://github.com/julia-actions/julia-format