Fix Footnotes Not Working Correctly #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove old separation between inline and bottom footnotes as it was causing issues. Instead combine css for bottom and inline footnotes and js for inline numbering in one function. This also drops dependency on HyperTextLiteral
propagate changes to example notebook
use PlutUI combine
add back text
update comments
propagate changes
add script id
fix name
fix name
change ordering
|
Sorry the footnotes got broken. I'll go ahead and merge this without testing so as to avoid delays. Please follow-up to test that it works and with any needed tweaks. |
|
Thanks so much for the speedy release. working as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footnotes have not been working since we tried to fix the display empty tuple issue - #20
Notice how the numbers don't show up in the example notebook
I decided to abandon the old "cssString" approach and use
PlutoUI.Combinefunction which makes things a lot cleaner in my opinionI also moved the
InlineandBottomprefix on all the functions so that everything starts withFootnotes- which I think helps discoverability