Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Foldable for PlutoUI.details, TwoColumn and ThreeColumn for Columns #61

Open
greimel opened this issue Oct 3, 2024 · 1 comment

Comments

@greimel
Copy link
Collaborator

greimel commented Oct 3, 2024

In #51 I add a function Columns that can display any number of columns. Its is a drop-in replacement for TwoColumn and ThreeColumn.

Should we remove TwoColumn and ThreeColumn?

In #60 I replace the implementation of Foldable with PlutoUI.details.

Should we remove Foldable and refer to PlutoUI.details in the docs?

@eford
Copy link
Collaborator

eford commented Oct 4, 2024

In #51 I add a function Columns that can display any number of columns. Its is a drop-in replacement for TwoColumn and ThreeColumn.

Should we remove TwoColumn and ThreeColumn?

I suggest that we leave these in the package, label them as deprecated, and replace the demonstrations of them in the example notebook.

In #60 I replace the implementation of Foldable with PlutoUI.details.

Should we remove Foldable and refer to PlutoUI.details in the docs?

I think the function name details is ambiguous. So I'd suggest that we keep the more clear name. Of course, we can credit PlutoUI and say that it's now just a more clear name (and demo) for details.
The one weird thing is that its now a function instead of a type, so the capitalization is confusing. I suppose we could create foldable and declare Foldable deprecated. I'm not really excited about that, but I can see the argument either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants