From f05de235f32644074f450b10ce654c248bf467c5 Mon Sep 17 00:00:00 2001 From: SimonDanisch Date: Thu, 27 May 2021 19:32:29 +0200 Subject: [PATCH 1/2] make sure tests at least run --- .github/workflows/RegisterAction.yml | 15 ++++++++++ test/runtests.jl | 44 ++++------------------------ 2 files changed, 20 insertions(+), 39 deletions(-) create mode 100644 .github/workflows/RegisterAction.yml diff --git a/.github/workflows/RegisterAction.yml b/.github/workflows/RegisterAction.yml new file mode 100644 index 0000000..e8d6202 --- /dev/null +++ b/.github/workflows/RegisterAction.yml @@ -0,0 +1,15 @@ +name: RegisterAction +on: + workflow_dispatch: + inputs: + version: + description: Version to register or component to bump + required: true + +jobs: + register: + runs-on: ubuntu-latest + steps: + - uses: julia-actions/RegisterAction@latest + with: + token: ${{ secrets.GITHUB_TOKEN }} diff --git a/test/runtests.jl b/test/runtests.jl index fcd86ce..efb24b3 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -1,42 +1,8 @@ -# Profiling inference -using SnoopCompile, MakieCore, ProfileView - -tinf = SnoopCompile.@snoopi_deep begin - s = MakieCore.Scene(500, 500) - scat = MakieCore.Scatter(randn(MakieCore.Point2f, 20)./2; strokecolor=:red) - push!(s, scat) - MakieCore.colorbuffer(s) -end - -fg = flamegraph(tinf) -ProfileView.view(fg) -staleinstances(tinf) # still need to dive into this! -flat = flatten(tinf) # flat[end-10:end-1] to get top 10 offenders - - -# Generating precompiles -using MakieCore, SnoopCompile -SnoopCompile.@snoopc ["--project=$(pwd())"] "compiles.log" begin - using MakieCore - s = MakieCore.Scene(500, 500) - scat = MakieCore.Scatter(randn(MakieCore.Point2f, 20)./2; strokecolor=:red) - push!(s, scat) - MakieCore.colorbuffer(s) - nothing -end -data = SnoopCompile.read("compiles.log") -pc = SnoopCompile.format_userimg(reverse!(data[2])) -SnoopCompile.write(joinpath(@__DIR__, "..", "src", "precompile.jl"), pc) +using Test, MakieCore +# Main tests live in Makie.jl, but we should write some unit tests going forward! +using MakieCore: @recipe, Attributes -# Measuring ttfp -@time begin - using MakieCore - @time begin - s = MakieCore.Scene(500, 500) - scat = MakieCore.Scatter(randn(MakieCore.Point2f, 20)./2; strokecolor=:red) - push!(s, scat) - MakieCore.colorbuffer(s) - nothing - end +@recipe(MyPlot) do scene + Attributes(test = 222) end From 91157a4c9a3184d076cd147861b88ad69a611f26 Mon Sep 17 00:00:00 2001 From: SimonDanisch Date: Thu, 27 May 2021 19:33:52 +0200 Subject: [PATCH 2/2] test the standard makie versions --- .github/workflows/CI.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 924f9aa..891b2d9 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -10,9 +10,8 @@ jobs: fail-fast: false matrix: version: - - '1.0' + - '1.4' - '1.6' - - 'nightly' os: - ubuntu-latest arch: