Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cargo-license] Add cargo-license #4092

Merged
merged 6 commits into from
Dec 19, 2021
Merged

[cargo-license] Add cargo-license #4092

merged 6 commits into from
Dec 19, 2021

Conversation

jeremiahpslewis
Copy link
Contributor

No description provided.

@giordano
Copy link
Member

Fix nproc syntax

???

@jeremiahpslewis
Copy link
Contributor Author

Fix nproc syntax

???

Github auto-title. Fixing.

@jeremiahpslewis jeremiahpslewis changed the title Fix nproc syntax [cargo-license] Add cargo-license Dec 18, 2021
@jeremiahpslewis
Copy link
Contributor Author

jeremiahpslewis commented Dec 18, 2021 •
edited
Loading

@giordano Once this passes and merges, can I use a BuildDependency("cargo_license_jll") in this project? Does that count as a legitimate bootstrap or does some ugly form of infinite recursion result...?

@giordano
Copy link
Member

As I said already, that must be a HostBuildDependency. See also https://docs.binarybuilder.org/stable/build_tips/#Dependencies-for-the-target-system-vs-host-system

@jeremiahpslewis
Copy link
Contributor Author

👍

giordano
giordano reviewed Dec 19, 2021
View reviewed changes
@giordano
Copy link
Member

@jeremiahpslewis please stop starting new jobs, we're having problems on the build machine, I'm doing some cleanup

@giordano giordano closed this Dec 19, 2021
@giordano giordano reopened this Dec 19, 2021
@giordano giordano merged commit 5d62793 into JuliaPackaging:master Dec 19, 2021
@jeremiahpslewis jeremiahpslewis deleted the jpsl/cargo-license branch December 19, 2021 22:13
KristofferC pushed a commit that referenced this pull request Dec 25, 2021
@jeremiahpslewis @giordano @KristofferC
[cargo-license] Add cargo-license (#4092)
14c2eb0 
* Add cargo-license

* Live by the env var, die by the env var.

* Fix

* Update C/cargo_license/build_tarballs.jl

Co-authored-by: Mosè Giordano <[email protected]>

* Drop unnecessary params

* Edit to retrigger build

Co-authored-by: Mosè Giordano <[email protected]>
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
@jeremiahpslewis @giordano @simeonschaub
[cargo-license] Add cargo-license (JuliaPackaging#4092)
5a7a557 
* Add cargo-license

* Live by the env var, die by the env var.

* Fix

* Update C/cargo_license/build_tarballs.jl

Co-authored-by: Mosè Giordano <[email protected]>

* Drop unnecessary params

* Edit to retrigger build

Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremiahpslewis @giordano