Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be better about upgrading old versions of packages #45

Open
tkelman opened this issue Aug 3, 2015 · 7 comments
Open

Be better about upgrading old versions of packages #45

tkelman opened this issue Aug 3, 2015 · 7 comments

Comments

@tkelman
Copy link
Contributor

tkelman commented Aug 3, 2015

ref JuliaLang/IJulia.jl#329 (comment)

We may want to only do this if we detect a Julia version upgrade - breaking an existing setup due to upstream changes from opensuse might not be pleasant for users.

@stevengj
Copy link

stevengj commented Aug 4, 2015

In the meantime, I'd like to add a workaround to the IJulia troubleshooting README. Is the right workaround to do rm(Pkg.dir("WinRPM","deps","usr"), recursive=true) followed by Pkg.build("IJulia")?

@tkelman
Copy link
Contributor Author

tkelman commented Aug 5, 2015

Removing is a bit drastic and leaves people without a way to get back to what they had before, so I'd rather recommend moving it to a backup name as a first step. Especially since the opensuse downloads are flaky for some people (#44), and fully upgrading all WinRPM packages could lead to a previously working setup breaking for some older releases of Julia.

@tkelman
Copy link
Contributor Author

tkelman commented Aug 5, 2015

Testing this now, and it looks like you'll also likely need to move Pkg.dir("WinRPM", "installed.list") out of the way as well, to force all packages to re-download.

@vtjnash
Copy link
Member

vtjnash commented Aug 5, 2015

WinRPM.update() only updates the metadata, so it isn't really the right function for this.

For this, there needs to be a WinRPM.upgrade function added that parses installed.list and calls Pkg.install on the list of all currently installed packages.

@stevengj
Copy link

stevengj commented Aug 5, 2015

Yes please!

@davidanthoff
Copy link
Collaborator

And another vote here, I just came across that for https://github.com/WizardMac/ReadStat.jl. The C library that ReadStat.jl wraps is probably going to be updated from time to time, and if I understand this issue here correctly, users won't get those updated DLLs automatically once they have downloaded an old version, right? That would probably be a pretty serious issue for that package.

@tkelman
Copy link
Contributor Author

tkelman commented Jul 15, 2016

you could add a validation hook to check that the binaries are acceptable. not sure whether that would force a redownload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants