Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation on non-compatible OSes #151

Closed
simonbyrne opened this issue Jul 27, 2018 · 5 comments
Closed

Allow installation on non-compatible OSes #151

simonbyrne opened this issue Jul 27, 2018 · 5 comments

Comments

@simonbyrne
Copy link
Contributor

simonbyrne commented Jul 27, 2018

Given that Pkg3 doesn't support OS-specific dependencies (JuliaLang/Pkg.jl#165), there needs to be a way to install this on incompatible OSes. The main problem is deps/build.jl (which is called at installation time) and attempts to call WinRPM.update(): could this be removed?

@simonbyrne
Copy link
Contributor Author

Alternatively we could put it behind an iswindows() check? (though from what I understand it also works on rpm-based linux distros?)

@tkelman
Copy link
Contributor

tkelman commented Jul 28, 2018

It should work on non-rpm distros as well, theoretically. Has been used in the past to download the same windows cross-compiled libraries from Linux or Mac for testing purposes in wine or similar.

@simonbyrne
Copy link
Contributor Author

Do we need to run update on installation?

@tkelman
Copy link
Contributor

tkelman commented Jul 28, 2018

Can't remember what the need/justification for that is - but given the custom applications this has only ever been used for on non-Windows, making that particular step Windows-only by default should be fine.

@NHDaly
Copy link

NHDaly commented Aug 1, 2018

Thanks for taking the initiative to fix this, Simon! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants