Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make (Abstract)FeaturedGraph subtype LightGraphs.AbstractGraphs #50

Open
CarloLucibello opened this issue Jul 21, 2021 · 1 comment
Open

Comments

@CarloLucibello
Copy link

Since FeaturedGraph already implements some of the core LightGraphs methods, it can be convenient to redefine

abstract type AbstractFeaturedGraph <: AbstractGraph{Int} end

so that we can access the full set of LightGraphs functionalities.
This approach is being experimented int FluxML/GeometricFlux.jl#204

@yuehhua
Copy link
Collaborator

yuehhua commented Jul 22, 2021

Oh! So you want to make the same set of APIs as LightGraphs methods do. For compatibility, it is great. However, I haven't checked the APIs defined for AbstractGraph and if these APIs are suitable for AbstractFeaturedGraph. Due to the reason, I haven't decided to make it as a subtype of AbstractGraph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants