Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x can become NaN #235

Closed
jwscook opened this issue Mar 26, 2020 · 3 comments · Fixed by #244
Closed

x can become NaN #235

jwscook opened this issue Mar 26, 2020 · 3 comments · Fixed by #244

Comments

@jwscook
Copy link

jwscook commented Mar 26, 2020

I've found that x can become NaN during a run, but the solve is not terminated. This line

NLsolve.jl/src/nlsolve/utils.jl

Line 19 in 9b4c7b3

if !any(isnan, x_previous) && chebyshev(x, x_previous) <= xtol
appears to be related and seems to indicate that NaNs are acceptable, and presumably may turn back to regular numbers. Is this right?
@pkofod
Copy link
Member

pkofod commented Jun 11, 2020

I would not expect them to. That should stop if it sees NaN. I'm not sure why it's written like that. Thanks.

@jwscook
Copy link
Author

jwscook commented Jun 11, 2020

No probs 😄

@pkofod pkofod mentioned this issue Jun 12, 2020
Merged
@pkofod
Copy link
Member

pkofod commented Jun 12, 2020

#244 should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better convergence assessment. JuliaNLSolvers/NLsolve.jl
2 participants
@pkofod @jwscook