-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add min/maximum(abs) #196
base: master
Are you sure you want to change the base?
add min/maximum(abs) #196
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 99.11% 94.84% -4.27%
==========================================
Files 6 6
Lines 225 291 +66
==========================================
+ Hits 223 276 +53
- Misses 2 15 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a comment to improve the test coverage. Other changes look great to me!
@test extrema(abs, iv"[-3, 2)") == (0, 3) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a bit tedious, but could you add tests like this?
@test extrema(abs, iv"[-3, 2)") == (0, 3) | |
end | |
@test extrema(abs, iv"[-3, 2)") == (0, 3) | |
@test_throws ArgumentError minimum(abs, 2..1) | |
@test_throws ArgumentError minimum(abs, iv"(1,2)") | |
@test_throws ArgumentError minimum(abs, iv"[-3,-1)") | |
@test_throws ArgumentError minimum(abs, iv"(1,3]") | |
@test_throws ArgumentError maximum(abs, 2..1) | |
@test_throws ArgumentError maximum(abs, iv"(1,2)") | |
@test_throws ArgumentError maximum(abs, iv"(-3,-1]") | |
@test_throws ArgumentError maximum(abs, iv"[1,3)") | |
end |
No description provided.