Provide range methods for OpenInterval and Interval{:open,:closed}
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methods already exist for ClosedInterval and Interval{:closed,:open};
these new methods complete the set of range extensions for each interval
type.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
==========================================
- Coverage 99.11% 98.12% -1.00%
==========================================
Files 6 6
Lines 225 266 +41
==========================================
+ Hits 223 261 +38
- Misses 2 5 +3 ☔ View full report in Codecov by Sentry. |
|
@hyrodium it looks like the Julia 1.6 tests are failing because that version of Julia doesn't support all |
|
No just change the tests to test 'lts' and '1' |
Julia LTS is now at 1.10.5
|
@dlfivefifty Done. I'm not sure why Invalidations is failing now |
|
For some reason JET.jl is v0.8.x but the newest version is v0.9.x |
hyrodium
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods already exist for
ClosedIntervalandInterval{:closed,:open}; these new methods complete the set of range extensions for each interval type.