Release v2.0.0 #12
Merged
Release v2.0.0 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.0.0 had largely the same behavior that development versions did. In particular, `ilog2(x)` threw a `DomainError` for most integer types with `x` less than or equal to zero. But other types, such as `Float64` did not cause a `DomainError` to be thrown, and instead returned `ilog2(abs(x))`. Version `2.0.0` extends the behavior for integers to all types. Now there is a single entry point to `ilog2` that makes this check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 20 22 +2
=========================================
+ Hits 20 22 +2 ☔ View full report in Codecov by Sentry. |
One test is slightly different for Julia 1.5 and earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.0.0 had largely the same behavior that development versions did. In particular,
ilog2(x)threw aDomainErrorfor most integer types withxless than or equal to zero. But other types, such asFloat64did not cause aDomainErrorto be thrown, and instead returnedilog2(abs(x)).Version
2.0.0extends the behavior for integers to all types. Now there is a single entry point toilog2that makes this check.