Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance #7

Closed
milankl opened this issue Feb 12, 2020 · 1 comment
Closed

Performance #7

milankl opened this issue Feb 12, 2020 · 1 comment

Comments

@milankl
Copy link
Member

milankl commented Feb 12, 2020

This is currently only within x2 compared to Float16

julia> using BenchmarkTools, Float8s

julia> B1 = Float16.(rand(300,300));

julia> B2 = Float8.(rand(300,300));

julia> @btime Float32.($B1);
  281.829 μs (2 allocations: 351.64 KiB)

julia> @btime Float32.($B2);
  512.166 μs (2 allocations: 351.64 KiB)

julia> A = rand(Float32,300,300);

julia> @btime Float8.($A);
  981.933 μs (2 allocations: 88.02 KiB)

julia> @btime Float16.($A);
  673.638 μs (2 allocations: 175.89 KiB)

Maybe it helps to remove some of the if-clauses baked into function calls via multiple-dispatch, that are used to have type-flexibility for Float8 / Float8_4.

@JeffreySarnoff
Copy link
Member

I'd separate them, if only for simplicity.

@milankl milankl closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants