Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests with Aqua.jl #283

Merged
merged 5 commits into from
Apr 13, 2024
Merged

Add tests with Aqua.jl #283

merged 5 commits into from
Apr 13, 2024

Conversation

hyrodium
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (793d42e) to head (40c5e55).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   97.05%   96.54%   -0.52%     
==========================================
  Files           7        7              
  Lines         782      782              
==========================================
- Hits          759      755       -4     
- Misses         23       27       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kimikage
Copy link
Collaborator

kimikage commented Apr 13, 2024

I'm going to merge PR #278 first to pass the nightly build tests. Edit: Done!

@kimikage
Copy link
Collaborator

@@ -13,17 +13,22 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
FixedPointNumbersStatisticsExt = "Statistics"

[compat]
Aqua = "0.8"
Documenter = "0.27, 1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the test dependency on Documenter.jl by adding documentation with Documenter.jl I will open a PR for that later.


if VERSION >= v"1.6.0-DEV.816" # JuliaLang/julia #36962 # FIXME
@test isempty(detect_ambiguities(FixedPointNumbers))
else
@test isempty(detect_ambiguities(FixedPointNumbers, Base, Core))
end

Aqua.test_all(FixedPointNumbers)

This comment was marked as resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, that's right. Updated in 40c5e55. (Removing isempty(detect_ambiguities(FixedPointNumbers)) was my first motivation for this PR 😂)

@kimikage
Copy link
Collaborator

kimikage commented Apr 13, 2024

Most of the CI errors seem to be due to Codecov's limitations of token-less upload.
The cause of the julia-invalidations error has not been identified, but is unrelated to this PR.

@kimikage kimikage merged commit c010ff7 into JuliaMath:master Apr 13, 2024
5 of 20 checks passed
@kimikage
Copy link
Collaborator

Thanks!

@hyrodium
Copy link
Contributor Author

Thank you for maintaining this repository!

@kimikage
Copy link
Collaborator

The cause of the julia-invalidations error has not been identified, but is unrelated to this PR.

ERROR: Unsatisfiable requirements detected for package FlameGraphs [08572546]:
 FlameGraphs [08572546] log:
 ├─possible versions are: 0.1.0-1.0.0 or uninstalled
 ├─restricted by compatibility requirements with FixedPointNumbers [53c48c17] to versions: uninstalled
 │ └─FixedPointNumbers [53c48c17] log:
 │   ├─possible versions are: 0.9.0 or uninstalled
 │   └─FixedPointNumbers [53c48c17] is fixed to version 0.9.0-dev

🤣

@kimikage kimikage mentioned this pull request Apr 30, 2024
38 tasks
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request Apr 30, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request Apr 30, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
kimikage pushed a commit to kimikage/FixedPointNumbers.jl that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants