-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests with Aqua.jl #283
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 97.05% 96.54% -0.52%
==========================================
Files 7 7
Lines 782 782
==========================================
- Hits 759 755 -4
- Misses 23 27 +4 ☔ View full report in Codecov by Sentry. |
|
@@ -13,17 +13,22 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2" | |||
FixedPointNumbersStatisticsExt = "Statistics" | |||
|
|||
[compat] | |||
Aqua = "0.8" | |||
Documenter = "0.27, 1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can drop the test dependency on Documenter.jl by adding documentation with Documenter.jl I will open a PR for that later.
|
||
if VERSION >= v"1.6.0-DEV.816" # JuliaLang/julia #36962 # FIXME | ||
@test isempty(detect_ambiguities(FixedPointNumbers)) | ||
else | ||
@test isempty(detect_ambiguities(FixedPointNumbers, Base, Core)) | ||
end | ||
|
||
Aqua.test_all(FixedPointNumbers) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, that's right. Updated in 40c5e55. (Removing isempty(detect_ambiguities(FixedPointNumbers))
was my first motivation for this PR 😂)
Most of the CI errors seem to be due to Codecov's limitations of token-less upload. |
Thanks! |
Thank you for maintaining this repository! |
🤣 |
No description provided.