-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Invalidations.yml #259
Conversation
This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency. See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 6 6
Lines 767 767
=======================================
Hits 714 714
Misses 53 53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I don't see a problem with this per se, but I do have a question as to who this is for. |
Whoever makes a PR increasing the number of invalidations has a chance to look at them? |
Since this package is relatively low-level, I think invalidation is a julia problem unless writing "too rude" code. |
The versions of several actions are outdated, but I will rely on dependabot. |
Although this PR was merged under my responsibility, this workflow brought the very useful feature of ❌-marking new PRs. 🎉
|
workaround: #287 |
This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.
See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29