Add get_embedding for GeneralUnitaryMultiplicationGroup
#670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbaran
added
extend manifold
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
==========================================
+ Coverage 99.36% 99.40% +0.03%
==========================================
Files 108 108
Lines 10597 10599 +2
==========================================
+ Hits 10530 10536 +6
+ Misses 67 63 -4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kellertuer
reviewed
Oct 26, 2023
|
You could still copy over the new action for the News.md change check and if you like even the new make.jl args if you like |
kellertuer
approved these changes
Oct 26, 2023
|
I've added the action but I will leave make.jl changes for later. I will try to fix the new bug first but today I'm too tired to figure it out. |
|
No problem, I can also do the make.jl in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for example by extrinsic mean calculation.
I've also added compat entries for stdlibs as written here: JuliaRegistries/General#94151.