From ae8fe22c9946cfed0983f8cbbf26761241656d81 Mon Sep 17 00:00:00 2001 From: Simon Jacobsson Date: Mon, 13 Nov 2023 21:44:12 +0100 Subject: [PATCH] is_flat returns true for Cholesky space and SPD with log-Cholesky metric. --- src/manifolds/CholeskySpace.jl | 4 ++-- src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/manifolds/CholeskySpace.jl b/src/manifolds/CholeskySpace.jl index ff3b9af276..24464c1579 100644 --- a/src/manifolds/CholeskySpace.jl +++ b/src/manifolds/CholeskySpace.jl @@ -132,9 +132,9 @@ end """ is_flat(::CholeskySpace) -Return false. [`CholeskySpace`](@ref) is not a flat manifold. +Return true. [`CholeskySpace`](@ref) is a flat manifold. """ -is_flat(M::CholeskySpace) = false +is_flat(M::CholeskySpace) = true @doc raw""" log(M::CholeskySpace, X, p, q) diff --git a/src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl b/src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl index 25c7d22d42..d829f3923e 100644 --- a/src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl +++ b/src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl @@ -99,10 +99,10 @@ end """ is_flat(::MetricManifold{ℝ,<:SymmetricPositiveDefinite,LogCholeskyMetric}) -Return false. [`SymmetricPositiveDefinite`](@ref) with [`LogCholeskyMetric`](@ref) -is not a flat manifold. +Return true. [`SymmetricPositiveDefinite`](@ref) with [`LogCholeskyMetric`](@ref) +is a flat manifold. """ -is_flat(M::MetricManifold{ℝ,<:SymmetricPositiveDefinite,LogCholeskyMetric}) = false +is_flat(M::MetricManifold{ℝ,<:SymmetricPositiveDefinite,LogCholeskyMetric}) = true @doc raw""" log(M::MetricManifold{ℝ,<:SymmetricPositiveDefinite,LogCholeskyMetric}, p, q)