From 158bbf221f7a593a83dbccc2867ba3a69f10ebe4 Mon Sep 17 00:00:00 2001
From: Ronny Bergmann <git@ronnybergmann.net>
Date: Sat, 11 Sep 2021 12:33:10 +0200
Subject: [PATCH 1/2] Apply suggestions from code review

Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
---
 src/manifolds/MetricManifold.jl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/manifolds/MetricManifold.jl b/src/manifolds/MetricManifold.jl
index eeb82718d7..bb81465404 100644
--- a/src/manifolds/MetricManifold.jl
+++ b/src/manifolds/MetricManifold.jl
@@ -54,7 +54,7 @@ abstract type RiemannianMetric <: AbstractMetric end
 @doc raw"""
     change_gradient(M::AbstractManifold, G2::AbstractMetric, p, X)
 
-Convert the gradint `X` at `p` on the[`AbstractManifold`](@ref) `M` from one metric to another.
+Convert the gradient `X` at `p` on the[`AbstractManifold`](@ref) `M` from one metric to another.
 
 Assume that for a real-valued function ``f: \mathcal M \to ℝ`` we are given the Riesz representer of the differential with respect to the metric ``g_2`` i.e.
 
@@ -78,7 +78,7 @@ the same basis of the tangent space, the equation reads
 ```
 where `\cdot^*`` denotes the conjugate transpose.
 
-and we obtain `c(x) = (G_1\backslask G_2)^*x `
+and we obtain ``c(X) = (G_1\backslash G_2)^*X``
 
 # Examples
 
@@ -90,7 +90,7 @@ Since the metric in ``T_p\mathbb S^2`` is the Euclidean metric from the embeddin
 
 Here, the default metric in `\mathcal P(3)` is the [`LinearAffineMetric`](@ref) and the transformation can be computed as ``pXp``
 """
-change_tangent(::AbstractManifold, ::AbstractMetric, ::Any, ::Any)
+change_gradient(::AbstractManifold, ::AbstractMetric, ::Any, ::Any)
 
 function change_tangent(M::AbstractManifold, G::AbstractMetric, p, X)
     if is_default_metric(M, G)

From 056e24ca1c8be5bcd4b9671bcb153a17e7fa8c1f Mon Sep 17 00:00:00 2001
From: Ronny Bergmann <git@ronnybergmann.net>
Date: Sat, 11 Sep 2021 12:38:40 +0200
Subject: [PATCH 2/2] Update src/manifolds/MetricManifold.jl

Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
---
 src/manifolds/MetricManifold.jl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/manifolds/MetricManifold.jl b/src/manifolds/MetricManifold.jl
index bb81465404..0a361c55fe 100644
--- a/src/manifolds/MetricManifold.jl
+++ b/src/manifolds/MetricManifold.jl
@@ -106,11 +106,11 @@ function change_tangent(M::AbstractManifold, G::AbstractMetric, p, X)
 end
 
 function change_metric(
-    ::MetricManifold{<:M,<:G},
+    ::MetricManifold{𝔽,M,G},
     ::G,
     p,
     X,
-) where {M<:AbstractManifold,G<:AbstractMetric}
+) where {𝔽,M<:AbstractManifold{𝔽},G<:AbstractMetric}
     return X
 end