From 3910dcd097485374060deb6947f35a051c6de2fb Mon Sep 17 00:00:00 2001 From: Mateusz Baran Date: Tue, 17 Oct 2023 11:45:55 +0200 Subject: [PATCH] remove deprecations, update NEWS --- NEWS.md | 5 ++++- src/deprecated.jl | 3 +-- test/test_deprecated.jl | 5 +---- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/NEWS.md b/NEWS.md index 3e4e6bc401..eedd76e525 100644 --- a/NEWS.md +++ b/NEWS.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added -- Vector bundles are generalized to fiber bundles. +- Vector bundles are generalized to fiber bundles. Old `BundleFibers` functionality was reworked to better match mathematical abstractions. Fiber bundle functionality is experimental and minor changes may happen without a breaking release, with the exception of `TangentBundle` which is considered to be stable. - `RotationTranslationAction` is introduced. ### Changed @@ -97,8 +97,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ``` - Argument order for type aliases `RotationActionOnVector` and `RotationTranslationActionOnVector`: most often dispatched on argument is now first. +- A more consistent handling of action direction was introduced. 4-valued `ActionDirection` was split into 2-valued `ActionDirection` (either left or right action) and `GroupActionSide` (action acting from the left or right side). See [https://github.com/JuliaManifolds/Manifolds.jl/issues/637](https://github.com/JuliaManifolds/Manifolds.jl/issues/637) for a design discussion. ### Removed - `ProductRepr` is removed; please use `ArrayPartition` instead. - Default methods throwing "not implemented" `ErrorException` for some group-related operations. Standard `MethodError` is now thrown instead. +- `LinearAffineMetric` was deprecated in a previous release and the symbol is now removed. + Please use `AffineInvariantMetric` instead. diff --git a/src/deprecated.jl b/src/deprecated.jl index 306e1334c0..8b13789179 100644 --- a/src/deprecated.jl +++ b/src/deprecated.jl @@ -1,2 +1 @@ -Base.@deprecate_binding LinearAffineMetric AffineInvariantMetric -export LinearAffineMetric + diff --git a/test/test_deprecated.jl b/test/test_deprecated.jl index 1947014240..5791392758 100644 --- a/test/test_deprecated.jl +++ b/test/test_deprecated.jl @@ -1,6 +1,3 @@ using Manifolds, ManifoldsBase, Test -@testset "Deprecation tests" begin - # Let's just test that for now it still works - @test LinearAffineMetric() === AffineInvariantMetric() -end +@testset "Deprecation tests" begin end