Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove full #20

Closed
andreasnoack opened this issue Aug 29, 2016 · 1 comment
Closed

Remove full #20

andreasnoack opened this issue Aug 29, 2016 · 1 comment

Comments

@andreasnoack
Copy link
Member

The trend in base is to get rid of full in favor of using convert. Here it should probably be without problems just to use Matrix(A) instead now that #19 has been merged.
@dkarrasch
Copy link
Member

Seems like this one can be closed. There is no occurence of full and the whole convert([Abstract]Array, ...) machinery from Base should work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreasnoack @dkarrasch