Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

norm(matrix) -> opnorm(matrix) in Julia 0.7 #10

Closed
stevengj opened this issue Jun 15, 2018 · 1 comment
Closed

norm(matrix) -> opnorm(matrix) in Julia 0.7 #10

stevengj opened this issue Jun 15, 2018 · 1 comment

Comments

@stevengj
Copy link
Member

It looks like may be using norm(matrix). In Julia 0.7, this will compute the Frobenius norm (vecnorm in Julia 0.6), due to JuliaLang/julia#27401. If you want the induced/operator norm as in Julia 0.6, use opnorm(matrix) instead, or Compat.opnorm(matrix) to work in 0.6 and 0.7 (JuliaLang/Compat.jl#577).

Note that, for testing purposes, rather than @test norm(A - B) ≤ tol, it is usually preferred to do @test A ≈ B or @test A ≈ B rtol=... (which uses isapprox).

@dlfivefifty
Copy link
Member

All the uses of norm were for testing purposes. I agree @test A ≈ B is preferable but it seems like a change not worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants