Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when initializing idrs! from [very near] solution #222

Closed
UserQuestions opened this issue Aug 23, 2018 · 2 comments · Fixed by #253
Closed

Error when initializing idrs! from [very near] solution #222

UserQuestions opened this issue Aug 23, 2018 · 2 comments · Fixed by #253

Comments

@UserQuestions
Copy link

When initializing idrs! from near to the solution, I receive an error that res is not defined. In looking closer, this is likely because res is referenced only on line 88 of idrs.jl and is not created anywhere. Line 88 is only called if normR<=tol, which is commented to occur when the "initial guess is a good enough solution." Replacing the return value in this case to X, log seems to work fine for me, though this may be bad/breaking for other reasons. I thought I would report this here in case this or another solution would be an easy fix. Thank you for putting this package together!

@mschauer
Copy link
Member

Thank you, this bug looks like an oversight when introducing a new mechanism to save the iteration history, 0c78f03#diff-6623a48145b6c4f92eec15da7d571fa4

@UserQuestions
Copy link
Author

Great to hear! Do you know what the second output of the return value should be in such a case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants