-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using cross affects ci workflow #614
Comments
Solution: We can just use vanilla cross without using the github action (or fork it) to add the prebuild hook functionality as described in their README but I haven't tested it. |
Just to add. This also means that apt-get install musl-tools didn't do anything because of |
Seems another project noticed - kanidm/webauthn-rs#301 I will open a pull request I guess. |
I think this is not really a problem right now? For the certificate situation things work on the PR now. I'm closing for now. |
I just found out that
juliaup
usesaction-rs/cargo
withcross
set to true which limits installing additional dependencies. These dependencies might be needed for some crates e.g. reqwest with native-tls enabled looks for openssl-dev. Thecross
tool can actually allow us to make a pre-build hook e.g. install libssl-dev or pkg-config inside the container before running cargo. See cross-rs/cross#678. Howeveraction-rs/cargo
seems to not have updated to include the pre-build hook. This makes sense since the functionality was added since 2022 whileaction-rs/cargo
has not been updated since 2021Assuming we have the prebuild hook option, we can do the following to install openssl devel inside the
cross
container:There is an open issue at actions-rs/cargo#115 but it's been two years since
action-rs/cargo
was updated.This issue affects my PR #613 where I cannot test if my changes build correctly
The text was updated successfully, but these errors were encountered: