Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix precompile(::MethodInstance) ccall signature #56595

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix precompile(::MethodInstance) ccall signature #56595

merged 1 commit into from
Nov 18, 2024

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 18, 2024

Prevents calling this method from triggering undefined behavior in C

@vtjnash vtjnash added the backport 1.11 Change should be backported to release-1.11 label Nov 18, 2024
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Nov 18, 2024
@vtjnash vtjnash merged commit b6eeef2 into master Nov 18, 2024
7 of 9 checks passed
@vtjnash vtjnash deleted the jn/precompile-MI branch November 18, 2024 20:17
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Nov 20, 2024
KristofferC pushed a commit that referenced this pull request Nov 22, 2024
@vtjnash @KristofferC
fix precompile(::MethodInstance) ccall signature (#56595)
580b2b8 
Prevents calling this method from triggering undefined behavior in C

(cherry picked from commit b6eeef2)
@KristofferC KristofferC mentioned this pull request Nov 22, 2024
Merged
34 tasks
KristofferC added a commit that referenced this pull request Nov 24, 2024
@KristofferC
Backports for Julia 1.11.3 (#56652)
040a6ce 
Backported PRs:
- [x] #56595 <!-- fix precompile(::MethodInstance) ccall signature -->
- [x] #56234 <!-- Revert "Extensions: make loading of extensions
independent of what packages are in the sysimage (#52841) -->
@KristofferC KristofferC mentioned this pull request Dec 3, 2024
Open
33 tasks
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtjnash @Keno @KristofferC @DilumAluthge